Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eni): Deprecate ENI as an input configuration format #5561

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Jul 26, 2024

Proposed Commit Message

chore(eni): Deprecate ENI as an input configuration format

Additional Context

The documentation around ENI had numerous factual errors: cloud-init doesn't support ENI configuration from OpenStack or OpenNebula datasources. Only NoCloud and ConfigDrive actually support this format. Both provide distro-agnostic alternatives.

I don't think that we want to support 3 user-facing input formats indefinitely. Energy would be better spent on cloud-init's networking stack if we focused users (and developer effort) onto fewer formats.

Deprecate and un-document.

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@github-actions github-actions bot added the documentation This Pull Request changes documentation label Jul 26, 2024
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@holmanb holmanb force-pushed the holmanb/deprecate-eni-input-format branch from ce02479 to b934ee3 Compare July 26, 2024 19:38
@holmanb
Copy link
Member Author

holmanb commented Jul 26, 2024

Pushed to fix ruff failure

@holmanb holmanb merged commit 15200a0 into canonical:main Jul 26, 2024
24 checks passed
holmanb added a commit to holmanb/cloud-init that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This Pull Request changes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants